Skip to content

SAML SLO does not clear session cookies on logout - #14017

Merged
DaanHoogland merged 2 commits into
apache:4.22from
shapeblue:ghi13997-saml-slo-session-not-cleared
Sep 4, 2026
Merged

SAML SLO does not clear session cookies on logout#14017
DaanHoogland merged 2 commits into
apache:4.22from
shapeblue:ghi13997-saml-slo-session-not-cleared

Conversation

@DaanHoogland

@DaanHoogland DaanHoogland commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Description

This PR...

Fixes: #13997

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@DaanHoogland DaanHoogland linked an issue Sep 1, 2026 that may be closed by this pull request
Session key is not cleared when SAML Global Log Out API is called #13997
Open
@DaanHoogland DaanHoogland mentioned this pull request Sep 1, 2026
Closed
@DaanHoogland DaanHoogland removed a link to an issue Sep 1, 2026
Session key is not cleared when SAML Global Log Out API is called #13997
Open
@codecov

codecov Bot commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.83%. Comparing base (e3c7b76) to head (1d7f622).
⚠️ Report is 1 commits behind head on 4.22.

Additional details and impacted files 
@@             Coverage Diff              @@
##              4.22   #14017       +/-   ##
============================================
+ Coverage     3.82%   17.83%   +14.00%     
- Complexity       0    16023    +16023     
============================================
  Files          449     5928     +5479     
  Lines        38177   534404   +496227     
  Branches      7072    65399    +58327     
============================================
+ Hits          1459    95287    +93828     
- Misses       36517   428297   +391780     
- Partials       201    10820    +10619
Flag Coverage Δ
uitests 3.82% <ø> (ø)
unittests 18.90% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

weizhouapache
weizhouapache approved these changes Sep 1, 2026
View reviewed changes

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@kiranchavala

kiranchavala commented Sep 1, 2026

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Sep 1, 2026

Copy link
Copy Markdown

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Sep 1, 2026

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19043

@DaanHoogland DaanHoogland moved this from Backlog to Ready in CloudStack Testing Sep 1, 2026
kiranchavala
kiranchavala approved these changes Sep 2, 2026
View reviewed changes

@kiranchavala kiranchavala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , Tested manually

Session key is cleared and the saml user is able to login after performing a logout

@DaanHoogland
DaanHoogland marked this pull request as ready for review September 2, 2026 16:36
@DaanHoogland

DaanHoogland commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

blueorangutan commented Sep 2, 2026

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Sep 3, 2026 •
edited
Loading

Copy link
Copy Markdown

[SF] Trillian test result (tid-16887)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 51244 seconds
Marvin logs: [archive removed]
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland
DaanHoogland merged commit 2b3cca6 into apache:4.22 Sep 4, 2026
24 checks passed
@github-project-automation github-project-automation Bot moved this from Ready to Done in CloudStack Testing Sep 4, 2026
@DaanHoogland
DaanHoogland deleted the ghi13997-saml-slo-session-not-cleared branch September 4, 2026 07:31
@DaanHoogland DaanHoogland added this to the 4.22.2 milestone Oct 28, 2026
@DaanHoogland DaanHoogland mentioned this pull request Oct 28, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kiranchavala kiranchavala kiranchavala approved these changes
@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

component:saml

Projects

CloudStack Testing
Status: Done

Milestone

4.22.2

Development

Successfully merging this pull request may close these issues.

5 participants

@DaanHoogland @kiranchavala @blueorangutan @weizhouapache @ACSGitBot